search

CalebBell / thermo

Thermodynamics and Phase Equilibrium component of Chemical Engineering Design Library (ChEDL)
MIT License
594 stars 114 forks source link

Implement extrapolation for integral; minor optimizations to extrapolation code #86

Closed yoelcortes closed 2 years ago

yoelcortes commented 2 years ago

Hi Caleb,

This pull request introduces the changes discussed in #85. I feel it's ready to merge, but would like to run it by you first just in case.

Edit: I'll add the same feature to the derivative in a few days on another pull request .

Thanks!

CalebBell commented 2 years ago

Hi Yoel,

I appreciate you preparing this pull request. Switching the extrapolation coefficients to all be stored in a dictionary was a clever choice. Well thought through! I would prefer if there were more tests for all of this code but otherwise go ahead and merge. I also hope to work on more of the extrapolation analytical implementations soon :)

Cheers,

yoelcortes commented 2 years ago

Thanks! I added a few preliminary tests to the integral, but there are still missing segments in the code that aren't tested yet. Most of these segments lead to exceptions, so hopefully this won't be an issue later on.

Thanks again!