search

CalebBell / thermo

Thermodynamics and Phase Equilibrium component of Chemical Engineering Design Library (ChEDL)
MIT License
594 stars 114 forks source link

Invalid Method specified in T_dependent_property documentation #90

Closed aakhtar8 closed 2 years ago

aakhtar8 commented 2 years ago

In the documentation of T_dependent_property, and plotting section. ethanol_psat is plotted using COOL_PROP. ethanol_psat.plot_T_dependent_property(Tmin=400, Tmax=500, methods=['COOL_PROP', 'WAGNER_MCGARRY', 'DIPPR_PERRY_8E'], pts=30) during tests it shows no "No such method available". ethanol_psat.all_methods also doesn't list COOL_PROP as available method. >>> ethanol_psat.all_methods {'EDALAT', 'LEE_KESLER_PSAT', 'VDI_TABULAR', 'WAGNER_MCGARRY', 'AMBROSE_WALTON', 'SANJARI', 'ANTOINE_POLING', 'DIPPR_PERRY_8E', 'WAGNER_POLING', 'BOILING_CRITICAL', 'VDI_PPDS'}

either example should be updated, or the method validitiy should be checked

CalebBell commented 2 years ago

Hi, The Coolprop method is from a third-party library, http://www.coolprop.org/ You will need to install it separately. Sincerely, Caleb

aakhtar8 commented 2 years ago

Hello, just to calrify, I wanted an update in thermo documentation so it does not throw an error

On Sun, 5 Dec 2021, 7:10 am Caleb Bell, @.***> wrote:

Closed #90 https://github.com/CalebBell/thermo/issues/90.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CalebBell/thermo/issues/90#event-5716283487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIFZQFMJVTZRMHKBZPB4I33UPLCZXANCNFSM5H6B57XQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

CalebBell commented 2 years ago

Hi, I really don't understand what you are saying. The documentation runs fine on my machine, with CoolProp installed. You can also install CoolProp and check that the documentation works. If you are in the root directory of this repository, and have pytest installed, you can run the doctests with: pytest --doctest-glob='*.rst' docs

If you are not happy can you be more clear?