CalebEverett / arloader

Rust command line application and client for uploading files to Arweave.
Apache License 2.0
83 stars 23 forks source link

Crash happen when file reach to certain size #13

Closed leozc closed 2 years ago

leozc commented 2 years ago

When media file size larger 10MB, it crashed arloader-0.1.55/src/commands.rs:743:26

thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', /Users/leozc/.cargo/registry/src/github.com-1ecc6299db9ec823/arloader-0.1.55/src/commands.rs:743:26
stack backtrace:
   0: _rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::panic_bounds_check
   3: arloader::commands::command_upload_nfts::{{closure}}
   4: arloader::main::{{closure}}
   5: arloader::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
    let log_dir = if let Some(log_dir) = log_dir {
        log_dir
    } else {
        let parent_dir = path_chunks[0].0[0].parent().unwrap();
        arweave.create_log_dir(parent_dir).await?
    };
CalebEverett commented 2 years ago

Try increasing the bundle size to be bigger than your file size. --bundle-size 100 will increase it to 100mb.

On Tue, Feb 1, 2022, 8:26 PM Leo Liang @.***> wrote:

When media file size larger 10MB, it crashed arloader-0.1.55/src/commands.rs:743:26

thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', /Users/leozc/.cargo/registry/src/github.com-1ecc6299db9ec823/arloader-0.1.55/src/commands.rs:743:26 stack backtrace: 0: _rust_begin_unwind 1: core::panicking::panic_fmt 2: core::panicking::panic_bounds_check 3: arloader::commands::command_upload_nfts::{{closure}} 4: arloader::main::{{closure}} 5: arloader::main note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.

let log_dir = if let Some(log_dir) = log_dir {
    log_dir
} else {
    let parent_dir = path_chunks[0].0[0].parent().unwrap();
    arweave.create_log_dir(parent_dir).await?
};

— Reply to this email directly, view it on GitHub https://github.com/CalebEverett/arloader/issues/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEIMQ3TX5GQQE5MKS7ZTBLUZCW7DANCNFSM5NLAB4IA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

leozc commented 2 years ago

That works - may make this become a more helpful error instead of a panic :)

Thanks!

CalebEverett commented 2 years ago

Will do - this actually came up once before as well. I think a bigger default bundle size would be better too. I'm not noticing much, if any, difference in upload speed between the tx/ endpoint used if 10MB or less and the chunk/ endpoint used if greater than that.