search

CalebMorris / react-moment-proptypes

React proptype validator for moment.js
49 stars 17 forks source link

Typescript support #48

Closed allan2 closed 3 years ago

allan2 commented 4 years ago

Any plans for TS support?

CalebMorris commented 4 years ago

I haven't done a React app in Typescript as of yet. Would you be looking for types support or something more?

allan2 commented 4 years ago

Just types support would be great :)

CalebMorris commented 4 years ago

Alright. Looking into adding a declaration file. Also trying to find some way of releasing the declaration without breaking existing Typescript applications.

CalebMorris commented 4 years ago

I've put up a pull request #49 and have tested against various React projects. To prevent any sort compile problems that could come about from introducing this I'm going to release it in v1.8.0.

@allan2 would you mind pulling down the branch and testing? Confirm it works well enough with your use-case and doesn't cause any problems.

tebatalla commented 3 years ago

Is v 1.8.0 coming any time soon?

CalebMorris commented 3 years ago

Sorry, changed jobs and had some priority shift. v1.8.0 is now published with Typescript types file. I tested against a couple test projects, but if you find an error with the types, please reach out with a new issue.