search

Caleblyx / pe

0 stars 0 forks source link

Module code checking is not performed on modules that are beyond the database of the application #2

Open Caleblyx opened 4 years ago

Caleblyx commented 4 years ago

image.png

I tried to add module codes that were illegetimate (i.e. it does not follow the correct format of module codes by NUS) and they were successful. I think it is critical that the format of module codes beyond the application's database should be checked as well, so that users do not add in module codes that are not sensible.

nus-se-bot commented 3 years ago

Team's Response

Firstly, we for the 'add' command to manually add modules, although we do not recommend users to manually add modules (see ss below), we assume that the user knows best when manually adding the modules. This is a design consideration to act as a saftely net to allow the flexibility of the user to input any newly created modules that are not in our database.

Secondly, not all valid modules will follow a certain format. For eg modules taken overseas during exchange programmes, DYOM modules... NUS do not have a rulebook of how module code should be or what a module code format is "sensible" or not "sensible".

SS of UG (section 2.3 Add Module) stating manually added module is not recommended. image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]