search

Calemi / CalemiUtils-1.12.2

Utilities that make your Minecraft experience better!
Apache License 2.0
1 stars 1 forks source link

Market Auto-sell/buy not working if placed BEFORE Bank #26

Closed DevTimur closed 5 years ago

DevTimur commented 5 years ago

If you place Market, setup auto-sell/buy funcion, and THEN place Bank in network, buy/sell operation will not go.

DevTimur commented 5 years ago

WAIT.... There is something finiky with Bank block... When i place Market on top of Bank block, automation does not work... I can buy and sell items, but not automate it.

Edit: I have a suspicion that Market tryes to read Bank as Inventory, and does not register Hopper on top, so automation does not work. Huh...

Calemi commented 5 years ago

Okay that should be a simple fix; just gotta check if it's not a bank. Is that the only problem, or is the placing before bank thing a problem too?

DevTimur commented 5 years ago

Sorry, wasn't sure how does it work in first place... So, if you got inventory with items you want to sell on top or bottom side of market it will automatically pull items, right? If so then no, placing order is not a problem. I just was confused how it works. But there is something annoying. You can't pump items out using pipes. Also, bank is considered an inventory and if you place market on top or bottom of bank then market try to scan it for items to sell, and automation just breaks. I guess same issue will happen if you got multiple inventories touching market?

Calemi commented 5 years ago

Yes that is how it was intended (except the bank bug,). That clears things up but couldn't you just pump items in and out of chests that are adjacent to the Market? That was the whole idea when I was developing it.

DevTimur commented 5 years ago

Market itself is slow. After all other mods I would expect to boost speed with better pumping system, but it limited by market itself. As if I could increase item buying speed, with upgrade for example.

DevTimur commented 5 years ago

I like how you implemented progress bar in quarry mining unit. It is understandable that one process takes X time, and can be boosted using upgrades. If you don't want to make batch sales, maybe you can add upgrade support? And you probaby should make so market operates with inventory only on top, how it done with interfaces. That will fit theme.

Calemi commented 5 years ago

Ah okay I understand. I'll implement the batch purchases and increase the speed a bit. Also I'll make the Market only read from the top and change the texture to indicate to players. And remove the bank bug of course. Sound good?

DevTimur commented 5 years ago

Perfect