Caleydo / caleydo

Caleydo - Visualization for Molecular Biology
http://caleydo.org
BSD 3-Clause "New" or "Revised" License
58 stars 14 forks source link

Rethink vertical positioning of KM plots in column #1587

Closed mstreit closed 11 years ago

mstreit commented 11 years ago

Evenly distributing the KM plots in the column would reduce the ugly band compression that we currently have.

sgratzl commented 11 years ago

the same holds for pathways.

I would suggest (it enough space is available) to put it at the same y-position as their corresponding cluster

mstreit commented 11 years ago

I agree, putting the bricks one the same y-pos as the bricks in the column the pathway or KM plots are depending on would result in nice bands. @cpartl How difficult is this to implement? It would be nice to change it for the NMC screenshots.

ngehlenborg commented 11 years ago

Don't forget that there are often situations in which one or more blocks are really small and their height is less than the height required for the KM or pathway plot - you'd have to handle this somewhat flexibly to avoid overlapping blocks.

Sent from a mobile device.

On Aug 29, 2013, at 3:33 AM, Marc Streit notifications@github.com wrote:

I agree, putting the bricks one the same y-pos as the bricks in the column the pathway or KM plots are depending on would result in nice bands. @cpartl How difficult is this to implement?

— Reply to this email directly or view it on GitHub.

mstreit commented 11 years ago

Yes, we discussed that already. I think equally distributing the bricks is the best and most universal solution.

cpartl commented 11 years ago

closed via b7a18cd

mstreit commented 11 years ago

Looks nice! However, before accepting the column, the bands are slightly off from the bricks. When hover over something, they are correct.

mstreit commented 11 years ago

The KM bricks now look a little bit detached though. Other opinions? a-d_mrna_microrna_overlap_m3_mi2_survival_stages

cpartl commented 11 years ago

Not sure what to do about the detached look. Maybe an unobtrusive column background would help, but not sure if we should do that.

mstreit commented 11 years ago

Let's keep it as it is for now. Thanks for fixing.