search

Caleydo / confusionflow-ui

Visualize learning dynamics in multi-class image classifiers (e.g., convolutional neural networks) 💬 @gfrogat @thinkh
https://confusionflow.org
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

added first version of hover functionality #224

Closed gfrogat closed 5 years ago

gfrogat commented 5 years ago

Closes #48.

the variable names are probably a bit off but I noticed that we're generally not than consistent throughout the app and use label or class interchangeably ...

thinkh commented 5 years ago

I refactored the code and added a mouseout listener. This way the highlighted curve in the detail view is cleared when the mouse hovers a cell outside the pinned row/column.

malevo-cell-hover-mouseout

thinkh commented 5 years ago

@gfrogat Please have a look if you agree with the current behavior. If yes, you can go ahead and merge this PR.

gfrogat commented 5 years ago

Looks great! Thanks a lot for the cleanup!

Regarding the mouseout event: I had this in my code too at one point, but I was not sure whether it's better to always reset the detail chart or to have a way to keep the current "hover-selection" active (e.g. when using different scalings) by moving out into an "independent" row/column.

Now the user always has to go forward and backward between the cell and the sliders.

Maybe we could bind the scaling to the mouse-wheel?

Update: Or we just keep it as it is now and change it if somebody complains

thinkh commented 5 years ago

Regarding the mouseout event: I had this in my code too at one point, but I was not sure whether it's better to always reset the detail chart or to have a way to keep the current "hover-selection" active (e.g. when using different scalings) by moving out into an "independent" row/column.

I thought of this, too. However, I find it more consistent now. However, I'm still not happy with the current solution, as I'm hovering "blind" when I focus on the detail chart. Because focusing on the mouse cursor and the detail chart at the same time is hard. ;-)

Maybe we could bind the scaling to the mouse-wheel?

I'm not so sure, whether this is a good idea or not. We can only do this, if we can ensure that the layout will always fit into the viewport (without vertical scrollbar).

Update: Or we just keep it as it is now and change it if somebody complains

I would keep it like this for now. We can change/modify it later if we have a better idea. And maybe it works like this for users.

gfrogat commented 5 years ago

ok, let’s merge it so we have it in the demo and discuss it in detail next week