search

Caleydo / mothertable

Mothertable Project @JKU-ICG 💬 @katush @mijar
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Remove columns from the top of matrix #392

Closed bikramkawan closed 7 years ago

bikramkawan commented 7 years ago

Closes https://github.com/Caleydo/taggle/issues/306

NMO13 commented 7 years ago

Works basically, however the URL hash won't be updated properly: bug

NMO13 commented 7 years ago

@bikramkawan If you want, I'll try to fix it.

NMO13 commented 7 years ago

Another problem: It is possible that support views have the same CSS class: image This is problematic since the removal of a support view relies on a unique class name.

bikramkawan commented 7 years ago

We can add the support view id in the end.

sgratzl commented 7 years ago

as far as I understood https://github.com/Caleydo/taggle/blob/master/src/SupportView.ts#L51 stores the DOM node for each support view, why not just removing this node instead of searching for it?