search

Caleydo / mothertable

Mothertable Project @JKU-ICG 💬 @katush @mijar
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Added sum for aggregation #409

Open bikramkawan opened 7 years ago

bikramkawan commented 7 years ago

Closes Issue : https://github.com/Caleydo/taggle/issues/395

sgratzl commented 7 years ago

what is the defined range min and max value that is used in the sum case? e.g. for the average aggregation it is still the min and max of the whole matrix

bikramkawan commented 7 years ago

I don't understand what you mean. The sum is only for the view of the matrix (stratified).

sgratzl commented 7 years ago

e.g. for showing the corresponding bar plot the minimum and maximum possible values are needed. In regular vector columns the values are taken from the description (desc.value.range). In case of aggregations functions like mean, min, max, q1, q3 the resulting values are still within this predefined range. However, this is not true for the sum aggregation.

sgratzl commented 7 years ago

you probably will see it in the artist use case. I expect that the bars of the sum aggregrated vector doesn't make sense

bikramkawan commented 7 years ago

I have moved this into new issue which is part of previous aggregation function also. #414

bikramkawan commented 7 years ago

Please see : https://github.com/phovea/phovea_core/pull/115

NMO13 commented 7 years ago

Is it correct, that all bars have the same length?

image

sgratzl commented 7 years ago

no, see my comments above. The defined range is 0...23 but the values are bigger (theoretically in this case: 0 ... 23*<number of column>)

bikramkawan commented 7 years ago

Yes that is incorrect I will remove the sum function but the range for the vector converted from the matrix view should be correct now from previous commit.