Closed oltionchampari closed 2 years ago
Removed the logic storing of the nameSets in the local state of theNamedSetsList
, there is no need to track the state of the sets twice
Tested again the sorting, editing, deleting, and adding a set from the ranking. Everything works as it should.
Closes https://github.com/Caleydo/tdp_bi_bioinfodb/issues/1359 Second part https://github.com/Caleydo/tdp_publicdb/pull/185
Developer Checklist (Definition of Done)
next-version: minor
) to this PR following semverSummary of changes
Throw the
EVENT_UPDATE_ENTRY_POINT
event globally in order for the menu to update when a new named set is added Alternatively we could create a EntryPointContext and import it in the dataset card but the current solution seemed more semantically correct to me.Added callbacks to reload the named sets when they are modified in the NamedSets.tsx (this fixes the error that right after deleting a named set and then open and close the dataset card, the named set still shows.
Screenshots