Closed dvzacharycutler closed 2 years ago
Also made a new ticket for improving the performance of the resizing with vis https://github.com/datavisyn/reprovisyn/issues/373. Currently it is quite slow, and if the dataset is large its a large hindrance
@dvzacharycutler Thanks for your changes and for creating the follow-up issue. There are two open points before we are ready to merge this PR.
Please refactor the CSS imports as mentioned above.
pointer-events: none
Additionally, I noticed that the dragging of the COSMIC view is not fixed using the
pointer-events: none
. Could you please have a look into this again?
Did you address this already? I couldn't find any SCSS-related changes.
Yes, I addressed the pointer events issue, the problem wasnt scss but me not realizing what the onDragEnd does. Instead set the flag for dragging in the MosaicWindow onChange, and turned it off in onRelease. Will fix the imports now
Yes, I addressed the pointer events issue, the problem wasnt scss but me not realizing what the onDragEnd does. Instead set the flag for dragging in the MosaicWindow onChange, and turned it off in onRelease.
Ok, thanks for the explanation.
Closes https://github.com/datavisyn/reprovisyn/issues/328
Developer Checklist (Definition of Done)
next-version: minor
) to this PR following semverSummary of changes
Screenshots
https://user-images.githubusercontent.com/87644761/166956392-4d00c045-e95f-4fdd-bf13-fe9f4d348047.mp4