Caleydo / ordino

Target discovery platform for exploring rankings of genes, disease models, and other entities. @JKU-ICG @datavisyn
http://caleydo.org/
Mozilla Public License 2.0
11 stars 2 forks source link

Adding React Mosaic #390

Closed dvzacharycutler closed 2 years ago

dvzacharycutler commented 2 years ago

Closes https://github.com/datavisyn/reprovisyn/issues/328

Developer Checklist (Definition of Done)

Summary of changes

Screenshots

https://user-images.githubusercontent.com/87644761/166956392-4d00c045-e95f-4fdd-bf13-fe9f4d348047.mp4

dvzacharycutler commented 2 years ago

Also made a new ticket for improving the performance of the resizing with vis https://github.com/datavisyn/reprovisyn/issues/373. Currently it is quite slow, and if the dataset is large its a large hindrance

thinkh commented 2 years ago

@dvzacharycutler Thanks for your changes and for creating the follow-up issue. There are two open points before we are ready to merge this PR.

Refactor CSS imports

Please refactor the CSS imports as mentioned above.

Add pointer-events: none

Additionally, I noticed that the dragging of the COSMIC view is not fixed using the pointer-events: none. Could you please have a look into this again?

ordino-react-mosaic-dragging

Did you address this already? I couldn't find any SCSS-related changes.

dvzacharycutler commented 2 years ago

Yes, I addressed the pointer events issue, the problem wasnt scss but me not realizing what the onDragEnd does. Instead set the flag for dragging in the MosaicWindow onChange, and turned it off in onRelease. Will fix the imports now

thinkh commented 2 years ago

Yes, I addressed the pointer events issue, the problem wasnt scss but me not realizing what the onDragEnd does. Instead set the flag for dragging in the MosaicWindow onChange, and turned it off in onRelease.

Ok, thanks for the explanation.