Caleydo / ordino

Target discovery platform for exploring rankings of genes, disease models, and other entities. @JKU-ICG @datavisyn
http://caleydo.org/
Mozilla Public License 2.0
11 stars 2 forks source link

Fix app crash when replacing views with object ref from `graph.findOrAddObject()` #405

Closed thinkh closed 2 years ago

thinkh commented 2 years ago

Fixes #402

Developer Checklist (Definition of Done)

Summary of changes

Screenshots

ordino-replace-view-findOrAddObject

thinkh commented 2 years ago

@rumersdorfer I've tested this PR with Ordino Public and it worked as before. However, it would be good to have a second opinion and testing cycle for Ordino. Please test Ordino Daily against a local Ordino instance with this PR. Check out the following branches in your local Ordino workspace:

image

Test if all actions regarding opening, closing and replacing a second view are still working as expected and if old provenance tracks (i.e., exported from Ordino Daily and imported locally) still result in the same state.

Please post your result here and if everything works submit a successful review. Let me know if you have further questions. Thanks.

rumersdorfer commented 2 years ago

@thinkh @oltionchampari Bug is fixed in Indications. 👍

rumersdorfer commented 2 years ago

Bug is also fixed in Ordino. 👍