Closed dvzacharycutler closed 2 years ago
Coming from the open questions regarding the typing in https://github.com/datavisyn/reprovisyn/pull/485#pullrequestreview-1049054999, I added Ordino-specific view plugin desc.
OrdinoSimpleViewPluginType
extends the VisynSimpleViewPluginType
(e.g., for proxy views)OrdinoDataViewPluginType
extends the VisynDataViewPluginType
(e.g., for general vis view)icon
property to plugin desc
Closes (https://github.com/datavisyn/reprovisyn/issues/437)
Also needs https://github.com/datavisyn/reprovisyn/pull/485 to work properly (see the icons)
Developer Checklist (Definition of Done)
next-version: minor
) to this PR following semverSummary of changes
https://user-images.githubusercontent.com/87644761/179503300-b677cb57-4fd5-475b-8b09-8be174a6904f.mp4
https://user-images.githubusercontent.com/87644761/179503188-75e856ce-b582-49b6-a720-1103fc8bc80b.mp4
https://user-images.githubusercontent.com/87644761/179504131-8873083e-25d4-4a2e-ae85-f2e29b57bd20.mp4
Screenshots