Caleydo / ordino

Target discovery platform for exploring rankings of genes, disease models, and other entities. @JKU-ICG @datavisyn
http://caleydo.org/
Mozilla Public License 2.0
11 stars 2 forks source link

Animation improvements, view chooser icons #412

Closed dvzacharycutler closed 2 years ago

dvzacharycutler commented 2 years ago

Closes (https://github.com/datavisyn/reprovisyn/issues/437)

Also needs https://github.com/datavisyn/reprovisyn/pull/485 to work properly (see the icons)

Developer Checklist (Definition of Done)

Summary of changes

  1. View chooser changes. Few changes to the overall look, changed text color to black, bold the category titles. Added icons for each view. Views that are transitions (create a new workbench) have a chevron with the color of the resulting workbench. Normal views have an icon which is defined in the config (currently just via font awesome string name), in the color of the workbench.

https://user-images.githubusercontent.com/87644761/179503300-b677cb57-4fd5-475b-8b09-8be174a6904f.mp4

  1. Breadcrumb changes. Rounded the corners, added a bit of padding. Did this by messing with the paths in a kind of hacky way, open to suggestions to better ways code wise (BreadcrumbSvg.tsx). Also changed the way far away breadcrumbs operate. Now, breadcrumbs that are not the focus or the context are very small and contain no text. There is no aggregation still, which I think is mostly fine assuming our normal use cases (need at least ~10 workbenches before I think it starts to look bad). Also did a good amount of code cleanup in the breadcrumb code, which I think is helpful, mostly adding helper functions for identifying workbench order and using them everywhere.

https://user-images.githubusercontent.com/87644761/179503188-75e856ce-b582-49b6-a720-1103fc8bc80b.mp4

  1. Animation changes, both when dragging and switching between workbenches, where an icon is displayed on a view instead of the actual content (the same icon as in the view chooser). This looks a good amount cleaner I think, and also helps performance out slightly, though there is still a problem with performance in the animation when the vis component is open because plotly tries rendering even when only displaying the icon. Can see this a bit at the end of the video. Need to look into that at some point.

https://user-images.githubusercontent.com/87644761/179504131-8873083e-25d4-4a2e-ae85-f2e29b57bd20.mp4

Screenshots

thinkh commented 2 years ago

Coming from the open questions regarding the typing in https://github.com/datavisyn/reprovisyn/pull/485#pullrequestreview-1049054999, I added Ordino-specific view plugin desc.