Pass the start menu mode to the tabs - Githubissues

Caleydo / ordino

Target discovery platform for exploring rankings of genes, disease models, and other entities. @JKU-ICG @datavisyn

http://caleydo.org/

Mozilla Public License 2.0

11 stars 2 forks source link

Pass the start menu mode to the tabs #422

Closed oltionchampari closed 2 years ago

oltionchampari commented 2 years ago

Closes https://github.com/datavisyn/reprovisyn/issues/346

Developer Checklist (Definition of Done)

Issue

[ ] All acceptance criteria from the issue are met
[x] Tested in latest Chrome/Firefox

UI/UX/Vis

[ ] Requires UI/UX/Vis review
- [ ] Reviewer(s) are notified (tag assignees)
- [ ] Review has occurred (link to notes)
- [ ] Feedback is included in this PR
- [ ] Reviewer(s) approve of concept and design

Code

[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[x] Descriptive title for this pull request is provided (will be used for release notes later)
[x] Reviewer and assignees are defined
[x] Add type label (e.g., bug, feature) to this pull request
[x] Add release label (e.g., release: minor) to this PR following semver
[x] The PR is connected to the corresponding issue (via Closes #...)
[x] Summary of changes is written

Summary of changes

Removed the close button when there is no open workbench in the background

Screenshots

grafik

Additional notes for the reviewer(s)

Should we make the first workbench closable? I do not know why we removed that
The build is failing as far as i see because of some repo changes.

oltionchampari commented 2 years ago

Closed in favor of https://github.com/datavisyn/reprovisyn/pull/523