Caleydo / ordino

Target discovery platform for exploring rankings of genes, disease models, and other entities. @JKU-ICG @datavisyn
http://caleydo.org/
Mozilla Public License 2.0
11 stars 2 forks source link

Open second view is broken after visyn script merge #424

Open thinkh opened 2 years ago

thinkh commented 2 years ago

Environment

Steps to reproduce the bug

  1. https://ordino-daily.caleydoapp.org/app/?
  2. Open a list of genes
  3. Select genes
  4. Open any second view

Observed Behavior

The second view does not open. The dev console shows the following error.

ViewWrapper.ts:343 Uncaught (in promise) TypeError: $app.scrollTo is not a function
    at ViewWrapper.scrollIntoView (ViewWrapper.ts:343:17)
    at ViewWrapper.modeChanged (ViewWrapper.ts:324:12)
    at set mode [as mode] (ViewWrapper.ts:422:10)
    at OrdinoApp.tsx:494:7
    at Array.forEach (<anonymous>)
    at OrdinoApp.focusImpl (OrdinoApp.tsx:484:22)
    at OrdinoApp.tsx:411:53
    at async ActionNode.createViewImpl [as f] (cmds.ts:67:22)

Expected Behavior

Switching to the second view should be possible again without an error.

Thanks for taking the time to fill out this bug report 🤗 Make sure there aren't any open/closed issues for this topic 😃

thinkh commented 2 years ago

With the visyn script merge (#421) the resolution of node modules has changed. That is probably the reason why jQuery plugins like scrollTo are not correctly loaded or registered to the "correct" jQuery instance. That's why the scrollTo function / plugin cannot be found and results in the error above.