fix: Replace jQuery scrollTo plugin with custom implementation - Githubissues

Caleydo / ordino

Target discovery platform for exploring rankings of genes, disease models, and other entities. @JKU-ICG @datavisyn

http://caleydo.org/

Mozilla Public License 2.0

11 stars 2 forks source link

fix: Replace jQuery scrollTo plugin with custom implementation #425

Closed thinkh closed 2 years ago

thinkh commented 2 years ago

Closes https://github.com/Caleydo/ordino/issues/424

Developer Checklist (Definition of Done)

Issue

[x] All acceptance criteria from the issue are met
[x] Tested in latest Chrome/Firefox

UI/UX/Vis

[ ] Requires UI/UX/Vis review
- [ ] Reviewer(s) are notified (tag assignees)
- [ ] Review has occurred (link to notes)
- [ ] Feedback is included in this PR
- [ ] Reviewer(s) approve of concept and design

Code

[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[x] Descriptive title for this pull request is provided (will be used for release notes later)
[x] Reviewer and assignees are defined
[x] Add type label (e.g., bug, feature) to this pull request
[x] Add release label (e.g., release: minor) to this PR following semver
[x] The PR is connected to the corresponding issue (via Closes #...)
[x] Summary of changes is written

Summary of changes

Replace jQuery scrollTo plugin with custom scroll implementation
Uses requestAnimationFrame to animate the scroll position

Screenshots

No actual change visible (except the fix). The behavior is like before.

ordino-fix-scrollto.webm

Thanks for creating this pull request 🤗