Improve typings for new session functions - Githubissues

Caleydo / ordino

Target discovery platform for exploring rankings of genes, disease models, and other entities. @JKU-ICG @datavisyn

http://caleydo.org/

Mozilla Public License 2.0

11 stars 2 forks source link

Improve typings for new session functions #427

Closed thinkh closed 1 year ago

thinkh commented 1 year ago

datavisyn/ordino_eins#525

Developer Checklist (Definition of Done)

Issue

[x] All acceptance criteria from the issue are met
[x] Tested in latest Chrome/Firefox

UI/UX/Vis

[ ] Requires UI/UX/Vis review
- [ ] Reviewer(s) are notified (tag assignees)
- [ ] Review has occurred (link to notes)
- [ ] Feedback is included in this PR
- [ ] Reviewer(s) approve of concept and design

Code

[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[x] Descriptive title for this pull request is provided (will be used for release notes later)
[x] Reviewer and assignees are defined
[x] Add type label (e.g., bug, feature) to this pull request
[x] Add release label (e.g., release: minor) to this PR following semver
[x] The PR is connected to the corresponding issue (via Closes #...)
[x] Summary of changes is written

Summary of changes

Await graph.push calls in OrdinoApp.pushStartViewToSession()
Subsequently add await to all related functions (e.g., initNewSessionAfterPageReload)
Refactor Ordino.initSessionImpl to async / await
Fix some of the any typings

Screenshots

No visual changes.

Additional notes for the reviewer(s)

It should not break anything but please test this branch with Ordino Public and see if the session is initialized and views open as before. Thanks.

Thanks for creating this pull request 🤗