Closed NuclearTea closed 3 months ago
Closes #17
Let me know when this is ready for review! This looks like some great work so far!
In the future, can you please make sure to name your branches like ali/config-variables-i17
to indicate your name, the feature, and the related issue number? Thanks :)
When this is ready, can you please rebase? You may find it beneficial to squash some commits too
Important note: you had an out-of-bounds memory situation when you constructed the demo strings as a certain length, and then set their max length to greater than their constructed length.
CONFIG_comapre_search_config_names
has a typo, and is entirely unnecessary. Its design does not offer any safety over using strcmp
, as you're relying on strlen
on c-strings, just one level up, with many extra lines of code.I've made the changes and pushed them. Have only done a tiny bit of testing. Can you please review the code, test it, and ensure you're happy with it? Thanks!
Using GitHub Desktop, you'll need to delete your local branch and then re-pull it.
49