CalgaryToSpace / CTS-SAT-1-OBC-Firmware

Firmware for the CTS-SAT-1 ("FrontierSat") mission. Runs on the STM32-based Onboard Computer.
MIT License
8 stars 0 forks source link

Telecommands: get and set config variables #101

Closed NuclearTea closed 3 months ago

NuclearTea commented 4 months ago

49

DeflateAwning commented 4 months ago

Closes #17

Let me know when this is ready for review! This looks like some great work so far!

In the future, can you please make sure to name your branches like ali/config-variables-i17 to indicate your name, the feature, and the related issue number? Thanks :)

DeflateAwning commented 4 months ago

When this is ready, can you please rebase? You may find it beneficial to squash some commits too

DeflateAwning commented 3 months ago

Important note: you had an out-of-bounds memory situation when you constructed the demo strings as a certain length, and then set their max length to greater than their constructed length.

Other comments in my changes:

Next Steps

I've made the changes and pushed them. Have only done a tiny bit of testing. Can you please review the code, test it, and ensure you're happy with it? Thanks!

Using GitHub Desktop, you'll need to delete your local branch and then re-pull it.