search

CaliCastle / PopMenu

A fully customizable popup style menu for iOS 😎
https://popmenu.cali.so
MIT License
1.6k stars 182 forks source link

Customization on highlight color #20

Open CaliCastle opened 5 years ago

CaliCastle commented 5 years ago

✍🏻 Issue Description

There's no way to customize the highlight color of a menu action.

lexrus commented 5 years ago

+1 for this issue. popmenu

But anyway, this lib is awesome. Thank you.

CaliCastle commented 5 years ago

@lexrus hi, thank you for choosing PopMenu and since I saw you're located in Shanghai then maybe we can resolve in Mandarin: 😄 这个黑色背景问题只存在于Xcode的Simulator模拟机，我用了真机测试并没有出现这个按住滑动的问题，我暂时不是很确定具体原因，不过推荐你试试build到真机中试试看还会不会发生此情况，如果会的话我会开个新issue去修复这个问题。 (P.S. 目前默认的highlight color是根据背景色而变的)

lexrus commented 5 years ago

谢谢你的回复，我试一下真机。 另外，我想要把阴影的 radius 改小一些，并且让文字水平居中，好像都不可以设置？

CaliCastle commented 5 years ago

@lexrus

修改shadow radius的话暂时不支持，我已添加到to-do，感谢提议 👍 下一个版本更新

目前设置在PopMenuViewController的第263行：

fileprivate func configureContentView() {
    ...
    containerView.addShadow(offset: .init(width: 0, height: 1), opacity: 0.5, radius: 20)
}