CaliCastle / PopMenu

A fully customizable popup style menu for iOS 😎
https://popmenu.cali.so
MIT License
1.6k stars 179 forks source link

横竖屏切换没有正确处理 #41

Open zdiovo opened 5 years ago

zdiovo commented 5 years ago

✔️ Issue Checklist

✍🏻 Issue Description

let actions = [
    PopMenuDefaultAction(title: "Some Text, Some Text, Some Text, Some Text, Some Text, Some Text"),
    PopMenuDefaultAction(title: "Some Text"),
    PopMenuDefaultAction(title: "Short"),
    PopMenuDefaultAction(title: "A Longer Text")
]
let popMenu = PopMenuViewController(actions: actions)
present(popMenu, animated: true, completion: nil)

运行在横屏状态下,UI显示正常, 然后切换到竖屏,显示就异常了 导致UI显示异常的原因主应该要是没有考虑title太长的情况 当title太长的情况,建议title可以像跑马灯一样滚动显示

💻 Environment

CaliCastle commented 5 years ago

感谢提出orientation的问题,暂时PopMenu没有对横竖屏切换的方法进行监听,所以导致出现的unexpected behavior。下一个更新我会加上,thanks!