search

CaliDog / EasySSL

SSL certificate parsing for humans
MIT License
36 stars 19 forks source link

Add certificate issuer parsing #11

Closed Synse closed 4 years ago

Synse commented 4 years ago

This adds support for parsing the issuer of a certificate using the same code used to parse subjects today.

I also added a simple test to ensure the values are parsed correctly, and updated the docs.

Fitblip commented 4 years ago

Hey this is rad, thanks for the PR. It looks like there are some merge conflicts, would you mind reconciling them? I'd be happy to approve/merge once things are green again!

Synse commented 4 years ago

👋 hey @Fitblip the merge conflicts are resolved. I also updated the docs to include emailAddress/signature_algorithm and added a test for signature algorithm parsing.

Let me know if there are any other changes you'd like to see.

xref #6 #7

Fitblip commented 4 years ago

Perfect, this looks great. Thanks for the PR 🚀

Fitblip commented 4 years ago

Released as 1.3.0! https://hex.pm/packages/easy_ssl/1.3.0