search

CaliDog / EasySSL

SSL certificate parsing for humans
MIT License
36 stars 19 forks source link

parse email address for certificate subject #6

Closed steffkes closed 4 years ago

steffkes commented 5 years ago

this pr does add functionality that parses the certificates subject email address. i've added a specific test to verify that it gets parsed correctly, the certificate was generated with the following command (in case we need to know later on):

openssl req -x509 -nodes -newkey rsa:4096 -keyout key.pem -out cert.pem -days 365 \
            -subj '/CN=certificate-with-email-address/emailAddress=mailbox@domain.tld'

wdyt @Fitblip? if you don't see this functionality within EasySSL i'd like to refactor the subject parsing, so that we can still extend the library for our project .. just let me know

Fitblip commented 4 years ago

Hi huge thanks for the PR! This looks great to me, I'm going to merge some other changes and cut a new version, will let you know when this is publicly available!

Fitblip commented 4 years ago

Should be live! https://hex.pm/packages/easy_ssl/1.2.1

Thanks again