search

CaliDog / certstream-go

Go library for connecting to CertStream
MIT License
140 stars 33 forks source link

Refactor the library to use channels to send messages instead of logs #4

Closed Fitblip closed 6 years ago

Fitblip commented 6 years ago

This should be the changes necessary to make certstream operate with 2 channels instead of a single channel and error logging (since error logging isn't the most pragmatic way of dealing with errors in golang).

This addresses #3

Fitblip commented 6 years ago

@mattmoyer - Do you mind giving this a gander when you get a moment and making sure this is up to snuff?

Fitblip commented 6 years ago

Hey @mattmoyer - that's a much better way to do that! Changes incoming!

Fitblip commented 6 years ago

@mattmoyer, this should be g2g now I think. Let me know if you'd change anything else!

Also thanks for turning me on to the pkg/errors package! I hadn't used it before, and it makes life nice and easy 😎