Remove the logging.basicConfig call from the listen_for_events function

CaliDog / certstream-python

Python library for connecting to CertStream

MIT License

426 stars 72 forks source link

Closed vEpiphyte closed 7 years ago

vEpiphyte commented 7 years ago

Its possible that this guy could be called from a non-MainThread, or prior to another logging.basicConfig call being done.

This could result in disrupting a parent application's logging strategy.

Fitblip commented 7 years ago

Hey @vEpiphyte - Thanks a bunch for the PR!

I've been meaning to remove that - it was left in for debugging purposes, and you saved me the effort, so huge thanks!

Cheers!

vEpiphyte commented 7 years ago

Awesome!