search

CaliDog / certstream-python

Python library for connecting to CertStream
MIT License
425 stars 72 forks source link

I've created a working snap for certstream-python #11

Closed kz6fittycent closed 6 years ago

kz6fittycent commented 6 years ago

The snap works and is already published. Let me know if you need further assistance/clarification about snaps.

Basically, it's now "easier" to distribute most Linux distros without needing to create a package for each.

It's also "self-updating" and won't affect any system libs.

Fitblip commented 6 years ago

Hey @kz6fittycent - thanks for the PR!

I'm not actually familiar with Snap, but I'm hesitant to include this as I don't think another distribution channel for Certstream is necessary. A simple pip3 install certstream should do the same thing on any modern linux distro - if that's not the case though please let me know and I'll reconsider.

EDIT: looking closer I'm concerned 1.) that it requires sudo to install, which my python package doesn't, and 2.) that it's pointed to a repository that you control.

Thanks!

kz6fittycent commented 6 years ago

Snaps provide you (the developer) with a safer method of ensuring your users are running the most current version of your application and they will receive updates automatically. It also allows you to "control" which version of Python they are using as the snap is completely self-contained.

As part of the PR, I was hoping that you could just take over the distribution of the snap (which is part of the co-op that Canonical has initiated).

Additionally, unlike pip installing, the updates are "less clunky". As far as requiring sudo to install the snap, it doesn't require it to run...

I'd add that if you don't want to maintain the snap distribution (which is relatively simple) I'd be happy to help your project out in that regard.

Lemme know.

Fitblip commented 6 years ago

Hey @kz6fittycent - I appreciate the work you've done to package this, but I haven't heard any chatter of certstream being hard to install/use from anyone, so I'm not sure that I'm willing to adopt this PR as I don't think introducing another distribution channel really gains us anything.

You're welcome to maintain those snaps at your own discretion though! Have a good rest of your week :)

kz6fittycent commented 6 years ago

Thanks will do! Have a great week.

James Tigert

"I am not bound to win, but I am bound to be true. I am not bound to succeed,but I am bound to live by the light that I have. I must stand with anybody that stands right, and stand with him while he is right, and part with him when he goes wrong." -Abraham Lincoln

On Tue, Apr 17, 2018 at 4:22 PM, Fitblip notifications@github.com wrote:

Hey @kz6fittycent https://github.com/kz6fittycent - I appreciate the work you've done to package this, but I haven't heard any chatter of certstream being hard to install/use from anyone, so I'm not sure that I'm willing to adopt this PR as I don't think introducing another distribution channel really gains us anything.

You're welcome to maintain those snaps at your own discretion though! Have a good rest of your week :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CaliDog/certstream-python/pull/11#issuecomment-382151315, or mute the thread https://github.com/notifications/unsubscribe-auth/AOJI-KJbuBhufeYxWcbt1b18D-PzenwVks5tpl0IgaJpZM4S33XR .