CaliDog / certstream-python

Python library for connecting to CertStream
MIT License
425 stars 72 forks source link

Include license and add changelog #4

Closed ghost closed 6 years ago

Fitblip commented 6 years ago

Unless you can give me a good justification for why I need this PR I'm not going to merge it.

ghost commented 6 years ago

The tarballs at pypi (https://pypi.python.org/pypi/certstream) don't include these files if you do not specify them in the file. Both files should be bundled together with the source code.

See also the Python Packaging tutorial: https://packaging.python.org/tutorials/distributing-packages/#license-txt

And why a changelog is useful: Because then the users of this program, other developers using it in other projects and packagers can easily see what has changes and what they need to change in their applications, libraries and packages. Otherwise they do either not take note of relevant changes or need to browse the commit history.

ghost commented 6 years ago

Any further comments on that?

ghost commented 6 years ago

Also see http://keepachangelog.com/ and http://reuse.software/

Fitblip commented 6 years ago

@wagner-certat - not trying to sound rude or disrespectful, but these seem like very pedantic changes, which is why I closed this issue. I'm not interested in maintaining an itemized changelog past github releases since this isn't my only open source project, and this repo has a grand total of 20 commits to it.

At the end of the day, this is open source software though, if you feel strongly and want to maintain a fork that does those things, you'll hear no objection from me.

ghost commented 6 years ago

Would it be possible to include the license in the tarball?

Fitblip commented 6 years ago

Will do!