search

CaliDog / certstream-python

Python library for connecting to CertStream
MIT License
427 stars 73 forks source link

WebSockets package updated which breaks certstream #42

Closed HugooB closed 3 years ago

HugooB commented 3 years ago

Hi!

It seems that https://github.com/websocket-client/websocket-client has changed something, which causes certstream to fail. Could somebody fix this issue? 

error from callback <bound method CertStreamClient._on_open of <certstream.core.CertStreamClient object at 0x1185f6e20>>: _on_open() takes 1 positional argument but 2 were given

Similar to #39 ?

Quick fix Pin requirements to websocket-client==0.57.0

srknzl commented 3 years ago

Using certstream==1.10 fixes for me.

Also, the error is like this for me

ERROR:websocket:error from callback <bound method CertStreamClient._on_message of <certstream.core.CertStreamClient object at 0x7f85ecd3ad30>>: _on_message() takes 2 positional arguments but 3 were given
  File "/home/serkan/.local/lib/python3.8/site-packages/websocket/_app.py", line 388, in _callback
    callback(self, *args)
ERROR:websocket:error from callback <bound method CertStreamClient._on_message of <certstream.core.CertStreamClient object at 0x7f85ecd3ad30>>: _on_message() takes 2 positional arguments but 3 were given
  File "/home/serkan/.local/lib/python3.8/site-packages/websocket/_app.py", line 388, in _callback
    callback(self, *args)
^CERROR:websocket:error from callback <bound method CertStreamClient._on_error of <certstream.core.CertStreamClient object at 0x7f85ecd3ad30>>: _on_error() takes 2 positional arguments but 3 were given
  File "/home/serkan/.local/lib/python3.8/site-packages/websocket/_app.py", line 388, in _callback
    callback(self, *args)
Fitblip commented 3 years ago

Hi folks, this should be fixed with #42

retpoline commented 3 years ago

Awesome, thanks @Fitblip!