search

CaliStyle / ng-intercom

Angular 7+ Wrapper for Intercom.com
MIT License
54 stars 46 forks source link

Intercom is not compatible with Angular 9 since .forRoot() got deprecated. #101

Open svelivala opened 4 years ago

svelivala commented 4 years ago

Versions

Description

wbhob commented 4 years ago

We don't claim that this package is compatible with Angular 9 (devDependencies point to v7). Secondly, if this is what you're referring to, forRoot is not deprecated, it just needs a quick modification. Third, please follow the issue template. If you'd like to fix this in a pull request, we'd be more than happy to look at your contribution, and we're looking for more open-source contributors.

@scott-wyatt we can talk about using {providedIn: 'root'} for this, since that's what all the other big Angular packages are transitioning to.

8tomo8 commented 4 years ago

Works perfectly fine for me in Angular 9

cgbrucezjy commented 4 years ago

for me, intercom boot works, but startTour doesnt work anymore. I notice the fetch call is success, but the iframe is not modified at all, therefor nothing happens.