search

CaliStyle / ng-intercom

Angular 7+ Wrapper for Intercom.com
MIT License
54 stars 46 forks source link

Upgrade to Angular v16 #108

Open martinpeterek opened 1 year ago

martinpeterek commented 1 year ago

Actual verion of package is incompatible with new Angular

PSingh-Unipd commented 1 year ago

Any updates on this issue? It seems that changing ModuleWithProviders to ModuleWithProviders<IntercomModule> might solve the issue(inside intercom.module.ts). I would appreciate any insights on this.

MoustafaMohA commented 1 year ago

I have the same issue when updated to Angular 16.

PSingh-Unipd commented 1 year ago

@MoustafaMohA This lib was forked some time ago, and it works fine with Angular 16. This is the link to the updated version of this lib: https://www.npmjs.com/package/@supy-io/ngx-intercom

MoustafaMohA commented 1 year ago

@PSingh-Unipd Thank you for replay, I will try to use the ngx-intercom and update to Angular 16.

martinpeterek commented 1 year ago

@PSingh-Unipd thank you, it works.

shardul-shah commented 6 months ago

@MoustafaMohA This lib was forked some time ago, and it works fine with Angular 16. This is the link to the updated version of this lib: https://www.npmjs.com/package/@supy-io/ngx-intercom

@PSingh-Unipd thank you for the link!

For anyone who stumbles here, I just want to comment on this. As of now - March 2024 - this forked package works well with the latest version of Angular - 17. It will work with 16 too. You may need to change your config object you pass to this.intercom.boot() function (I experienced this), because the forked version changes the interfaces a bit from the original ng-intercom package. Just do so if this is the case and you should be good to go.

Yaseen-Ahmed-N commented 2 months ago

if i am doing this this.intercom.boot({app_id: environment.intercomAppID, updateOnRouterChange: true}) it gives error that 'updateOnRouterChange' not a known property. Kindly anyone can tell me the interface of this object. @PSingh-Unipd please mention details of the new configuration which working fine.