search

CaliStyle / ng-intercom

Angular 7+ Wrapper for Intercom.com
MIT License
54 stars 46 forks source link

Test env #42

Closed scott-wyatt closed 6 years ago

scott-wyatt commented 6 years ago

So these test are failing because to get this to work with Yarn I had to remove the node engine restriction. It's hard to test that this will work as a library when it's not published to NPM, but this should fix at least one open issue and hopefully the AOT stuff.

scott-wyatt commented 6 years ago

It's just so strange, because it passes AOT and SSR in the package, but then when it's published, AOT can throw a complaint about the library Only initialized variables and constants can be referenced in decorators because the value of this variable is needed by the template compiler in config. Tracking this down it looks like it hates the way the interface class is exported. But hopefully this was fixed in the latest version of ng-packagr

scott-wyatt commented 6 years ago

Confirmed, this works with AOT and SSR now. It was an undocumented ng-packagr error were using an index barrel computed multiple result paths. Merging and publishing.