search

CaliStyle / ng-intercom

Angular 7+ Wrapper for Intercom.com
MIT License
54 stars 46 forks source link

Optionally load the config via forRoot #43

Closed sjroesink closed 6 years ago

sjroesink commented 6 years ago

Currently IntercomModule.forRoot forces you to provide the config when loading the module. This prevents config from being provided asynchronous.

This PR makes it optional to provide the config initially via IntercomModule.forRoot. The function Intercom.loadIntercom can then be called at a later point.

This fixes #28

scott-wyatt commented 6 years ago

@wbhob thoughts on this?

scott-wyatt commented 6 years ago

I'm closing this for now, I believe that most of this has been implemented in one form or another and the angular 6+ version is now available in master.

nitinkg7 commented 6 years ago

Which version to use for making config optional?

wbhob commented 6 years ago

with forRoot, config is required because it registers your appId. Without the app ID, Intercom will not work.