search

CaliStyle / ng-intercom

Angular 7+ Wrapper for Intercom.com
MIT License
54 stars 46 forks source link

appId being ignored in boot method #72

Closed Greatsamps closed 5 years ago

Greatsamps commented 5 years ago

Versions

Description

I have followed the instruction in the main readme, which indicates that the intercom appId can be overridden via a boot method which is what we require. The project we are working on has multiple appId's, depending on the domain that's being accessed.

Unless an appId is specified in the forRoot method, the intercom messenger does not load. Based on the documentation it would seem that the appId can be replaced via the boot method, but this is not the case.

wbhob commented 5 years ago

I have an idea for what to do here @scott-wyatt I'll try to make a PR this evening

Greatsamps commented 5 years ago

I have managed to fix this, let me know if you are interested in the solution...

wbhob commented 5 years ago

72 addresses this issue