search

CaliStyle / ng-intercom

Angular 7+ Wrapper for Intercom.com
MIT License
54 stars 46 forks source link

Fix build process #8

Closed humrochagf closed 7 years ago

humrochagf commented 7 years ago

When installing as a requirement at packages.json, it was not able to fetch the src and build the dist folder properly.

So this PR fixes the automatic build process that runs at the instalation of the package

wbhob commented 7 years ago

I already fixed this, just waiting for @scott-wyatt to publish. As a general rule, don't publish source files to NPM, it's bad practice.

humrochagf commented 7 years ago

get it, thx.

and just to better understanding of the process, how does the npm will generate the dist folder since it does not get the source and the dist isn't pre built at the repo?

wbhob commented 7 years ago

We build it with the prepublish npm command.

Wilson Hobbs CEO/Founder/Developer at Canal 11th Grade at The Lovett School

Personal Information E-mail: wilsonhobbs1@gmail.com Cell: (404) 719-3252 Website: www.wilsonhobbs.com Twitter/Instagram/Facebook: @wbhob

Canal Information E-mail: wilson@getcanal.com Web: www.getcanal.com Twitter/Instagram/Facebook: @getcanal

On Apr 30, 2017, 12:55 PM -0400, Humberto Rocha notifications@github.com, wrote:

get it, thx. and just to better understanding of the process, how does the npm will generate the dist folder since it does not get the source and the dist isn't pre built at the repo? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

wbhob commented 7 years ago

Why was this merged? I closed it because I already fixed it @scott-wyatt

wbhob commented 7 years ago

Shoot did I forget to close it?