CaliStyle / ng-intercom

Angular 7+ Wrapper for Intercom.com
MIT License
54 stars 46 forks source link

[fix] metadata issue, fixes #74 #83

Closed lucagouty closed 5 years ago

lucagouty commented 5 years ago

Summary of changes:

Honestly, I'm not sure what was the issue, but I found that fix in ngx-progressbar which had the same issue some time ago :

Other unrelated changes (I'll rollback if you want)

Intended/example use case:

Of course, first I made sure I was reproducing the issue, without this change, I get

ERROR in Error during template compile of 'CoreModule'
  Function calls are not supported in decorators but 'IntercomModule' was called.
: Unexpected value 'undefined' imported by the module 'CoreModule in /some/path/src/app/core/core.module.ts'
Error during template compile of 'CoreModule'
  Function calls are not supported in decorators but 'IntercomModule' was called.

With this fix, everything goes well now (Angular7, both ng build --prod and ng xi18n)

Checklist:

Closes issue: #74

scott-wyatt commented 5 years ago

Thank you for the PR! I'm going to close and reopen this to trigger the CI.

scott-wyatt commented 5 years ago

This will be released in #84 release 7.0.0-beta.1

wbhob commented 5 years ago

thanks so much for your work, Luca !