CaliStyle / ng-intercom

Angular 7+ Wrapper for Intercom.com
MIT License
54 stars 46 forks source link

Fix issue with routing performance when using updateOnRouterChange #98

Closed andy-hook closed 4 years ago

andy-hook commented 4 years ago

Fix for #97

Summary of changes:

Intended/example use case:

When using updateOnRouterChange the update would fire multiple times per route change causing performance problems. With this change the update will fire only once after a successful navigation.

Checklist:

Closes issue: #

scott-wyatt commented 4 years ago

Thanks @andy-hook! I’ll take a look to see what’s happening with the test.

andy-hook commented 4 years ago

Great, thank you @scott-wyatt

andy-hook commented 4 years ago

Hi @wbhob @scott-wyatt, thanks for looking at this. Is there anything more I can do to get this out in a patch release?

scott-wyatt commented 4 years ago

published