Closed willson556 closed 4 years ago
Because of the viral nature of strong-naming, it is recommended that publicly published .NET libraries are strong-named. Not strong-naming a .NET library excludes anyone who does need to strong-name their application or library from using it. Read more about .NET libraries and strong-naming in the .NET Library Guidance. Source: https://github.com/dotnet/runtime/blob/master/docs/project/strong-name-signing.md
Based on the above, this seems like a good idea for reasons aside from resolving #700.
Thanks, what I may do is push a revert to that last commit of mine and then rebase this PR.
Fine by me!
Reverted my commit, feel free to rebase, let's leave the target frameworks alone.
Although does having the different frameworks solve you issue? ie. Does just the strong naming problem fix it.
Just finished testing and it works for me regardless of whether the frameworks change is present. Rebased as requested and removed the TargetFrameworks
change in the Caliburn.Micro.Core
project.
Thanks
Possible solution to #700 Tweaks for consistent strong-naming. Also, reduced the number of targets required.