search

Caliburn-Micro / Caliburn.Micro

A small, yet powerful framework, designed for building applications across all XAML platforms. Its strong support for MV* patterns will enable you to build your solution quickly, without the need to sacrifice code quality or testability.
http://caliburnmicro.com/
MIT License
2.79k stars 776 forks source link

Support for MAUI #794

Closed KasperSK closed 2 years ago

KasperSK commented 2 years ago

Initial support for NET MAUI with platforms Android and Windows working and tested. Also had a chance to test on MacOS and it looks like that is working as well.

I might do a rewrite on this since in essence it is just a port of the current Xamarin setup to a MAUI setup.

Would love to have feedback.

inforithmics commented 2 years ago

Are you intrested in getting some help to make this compile again? or passing continous integration?

KasperSK commented 2 years ago

@inforithmics I have been busy trying to test on iOS and macOS and that is working now, so the next step would be to get this working and then merging this. I will have a go at it this weekend.

vb2ae commented 2 years ago

we should update the version in version.json to 5.0-beta before we merge it in

KasperSK commented 2 years ago

I wish thinking we might should prepend CAL_ to the other defines so that we can control them the issue was the MSBuild.sdk.extras defined NETCORE for UAP and that was not good for our setup.

I think we should bump the version aswell.

KasperSK commented 2 years ago

I have a bugfix we need to do before merging this.

vb2ae commented 2 years ago

@KasperSK okay. FYI I made a V4.0.210 branch incase we need to make a bugfix for the released version. I was thinking we should make a branch for the code used in each package released to nuget

KasperSK commented 2 years ago

@vb2ae I don't have any more changes for this branch would why disagree to merging this PR?

vb2ae commented 2 years ago

@KasperSK need to fix merge conflict then we can merge in