795 calburnmicro resolving performance - Githubissues

Caliburn-Micro / Caliburn.Micro

A small, yet powerful framework, designed for building applications across all XAML platforms. Its strong support for MV* patterns will enable you to build your solution quickly, without the need to sacrifice code quality or testability.

http://caliburnmicro.com/

MIT License

2.8k stars 778 forks source link

795 calburnmicro resolving performance #801

Closed vb2ae closed 2 years ago

vb2ae commented 2 years ago

Save some typeinfo in variables to prevent having to get it all the time

KasperSK commented 2 years ago

Looks like a small change, can we benchmark to verify that this will be faster?

vb2ae commented 2 years ago

Sure I will try and do that tonight

vb2ae commented 2 years ago

Before change

After

vb2ae commented 2 years ago

Changed key == null to string.isnullorempty(key)

KasperSK commented 2 years ago

Good find and nice job with the benchmarking. I think we should merge this. Do you have any more changes or should I go ahead and merge?

vb2ae commented 2 years ago

That is the last change for this issue. You can merge it. Do you have any PRs for me to review and merge?