search

Caliburn-Micro / Caliburn.Micro

A small, yet powerful framework, designed for building applications across all XAML platforms. Its strong support for MV* patterns will enable you to build your solution quickly, without the need to sacrifice code quality or testability.
http://caliburnmicro.com/
MIT License
2.79k stars 775 forks source link

Run CanCloseAsync with DispatcherPriority Input. #867

Closed Stannieman closed 11 months ago

Stannieman commented 1 year ago

This fixes https://github.com/AvaloniaUI/Avalonia/issues/12439

Stannieman commented 1 year ago

@vb2ae please wait with merging this, I found that it can hang the app when it tries to close a window that was shown as dialog.

Mrxx99 commented 1 year ago

@vb2ae please wait with merging this, I found that it can hang the app when it tries to close a window that was shown as dialog.

You can click the convert to draft button for this and when everything is ready convert it back by clicking "ready for review"

Stannieman commented 1 year ago

Thanks, I did not know it exists, the button is quite hidden 😅

Stannieman commented 1 year ago

Goddammit, that was a rookie mistake. It should be InvokeAsync instead of Invoke cause Invoke is blocking and that is not good.