Closed bjfultn closed 7 years ago
Name the APF iodine file apfiodine.sam to be compatible with changes I just made to grand.F. The file must have 1400001 lines, exactly like kecknso52p5.sam. We might as well use the same wavelength grid from 4950 to 6350 in steps of 0.001 Angstrom.
grand
is crashing when I try to run it on the simulated dataset without adding any INSTRUMENT flag into the obslist giving me the
STOP Last pixel index (_IDIM_+ibeg-1) > Data size (idim)
error.
Seems to work with the INSTRUMENT = "HIRES"
line in the obslist, but this crashes iGrand
Added instrument capability into iGrand, see commit bcca6e4
This was tested to work with the simulated data and produce the same results in the case that nothing is fixed.
Progress from Jeff's email:
I added logic to read APF spectra. For reference, here is the subset of the APF spectra I chose to retain in grand.F:
I added blaze function removal for APF. I'll show the blaze function fits tomorrow. They are not worth distracting you now.
I have not added logic to use a different iodine cell spectrum for APF.
It would be nice to know if the attached grand.F still works for an existing HIRES test case (simulated or actual observations). In other words, did I break HIRES. BJ could help with that.
I know the attached grand.F doesn't work for APF yet. NaNs take over almost immediately when grand computes the initial model. Jay could help with debugging. I will not work on the fortran code between now and the WebEx tomorrow.
I constructed the attached obslist. It has the new INSTRUMENT = "APF" specification. The B star iodine spectra referenced in obslist are available on Box: https://stsci.box.com/s/uvidxf0mrts4ixyyawkmtvtjxjspss1f. I suppressed fudge and specified an external wavelength file for APF (apf3348.wls):