California-Planet-Search / radvel

General Toolkit for Modeling Radial Velocity Data
http://radvel.readthedocs.io
MIT License
57 stars 52 forks source link

Minor bug in rv multipanel plot #350

Open zhexingli opened 3 years ago

zhexingli commented 3 years ago

There's a small bug when displaying the derived mpsini in the rv multipanel plot. See attached.

The derived mpsini is something like 0.1 solar mass but in the plot it displays 30 solar masses for some reasons

HD173902_radvel_results.pdf

A unrelated question.... in the derived_quantiles.csv file, is the unit for 'mpsini' always in Earth unit? What's 'musini' and what's the unit for it? Ty.

bjfultn commented 2 years ago

Yes, I believe mpsini is always in Earth units and musini is the mass ratio.

I'll try to track down that other little bug.

sealauren commented 2 years ago

This bug is still here (multipanel plot legend displays ~30 solar masses; should be 0.1 solar masses) -- I just saw it crop up in a similar case to what zhexingli described.

bjfultn commented 2 years ago

I looked into this for a few min, but I couldn't quickly find the culprit. @sealauren perhaps a student has time to dig into it and search for the bug?