Open vandalt opened 2 years ago
Yes, definitely send over a PR more kernels are always good.
I was actually unaware of celerite2
I'd have to do some research to see what it would take to transition over but I'm certainly not against it. The Python 3.6 requirement is not a problem as I no longer support Python 2.X.
There are no strict requirements but I almost always work with Python >= 3.7.4. Python 2 support for radvel has been 'use at your own risk' for quite awhile (1.2.x) and I don't think it will work these days but I haven't tested.
PEP8 standard is 80 characters. This may not be practiced 100% of the time in the existing code but it is the goal. 120 is fine for documentation lines if you need it.
Hello, I have a few use cases where
celerite
kernels other than the Quasi-Periodic one currently implemented in RadVel (mainly the SHO and Matern 3/2 ones) could be useful. I have implementations that seem to be working (it replicates what the currentCeleriteKernel
is doing but with different terms). I could send a PR with this if you are interested.I also have somewhat related questions:
celerite2
? Celerite seems to be in maintenance mode andcelerite2
has more active development, but it only supports Python 3.6 and later.Thanks!