Closed vandalt closed 2 years ago
Hi, In the MultipanelPlot class, when phase_ncols or phase_nrows are passed as keyword argument, it seems that they are never set as attribute. I think an else for each of them would fix this.
MultipanelPlot
phase_ncols
phase_nrows
else
https://github.com/California-Planet-Search/radvel/blob/a39924064a052ffc84703872225eee3f89447176/radvel/plot/orbit_plots.py#L74-L77
I'm happy to send a PR with this, but I preferred to open an issue first. Since the fix is simple, I thought you might prefer to add it directly.
Go ahead and submit a PR if you are there working in the code.
Fixed in PR #362 and will be released with 1.4.10
Hi, In the
MultipanelPlot
class, whenphase_ncols
orphase_nrows
are passed as keyword argument, it seems that they are never set as attribute. I think anelse
for each of them would fix this.https://github.com/California-Planet-Search/radvel/blob/a39924064a052ffc84703872225eee3f89447176/radvel/plot/orbit_plots.py#L74-L77
I'm happy to send a PR with this, but I preferred to open an issue first. Since the fix is simple, I thought you might prefer to add it directly.