`phase_ncols` and `phase_nrows` are not set as attribute when passed as arguments

California-Planet-Search / radvel

General Toolkit for Modeling Radial Velocity Data

http://radvel.readthedocs.io

MIT License

57 stars 52 forks source link

`phase_ncols` and `phase_nrows` are not set as attribute when passed as arguments #357

Closed vandalt closed 2 years ago

vandalt commented 2 years ago

Hi, In the MultipanelPlot class, when phase_ncols or phase_nrows are passed as keyword argument, it seems that they are never set as attribute. I think an else for each of them would fix this.

https://github.com/California-Planet-Search/radvel/blob/a39924064a052ffc84703872225eee3f89447176/radvel/plot/orbit_plots.py#L74-L77

I'm happy to send a PR with this, but I preferred to open an issue first. Since the fix is simple, I thought you might prefer to add it directly.

bjfultn commented 2 years ago

Go ahead and submit a PR if you are there working in the code.

bjfultn commented 2 years ago

Fixed in PR #362 and will be released with 1.4.10