California-Planet-Search / radvel

General Toolkit for Modeling Radial Velocity Data
http://radvel.readthedocs.io
MIT License
57 stars 52 forks source link

Support for additional `celerite` kernels #358

Closed vandalt closed 11 months ago

vandalt commented 2 years ago

Hello,

As discussed in #353, I implemented the Matern32Term and SHOTerm from celerite within the RadVel gp framework. This PR contains:

I saw that there is a gp-multiply-kernels branch, so I was wondering if I should rebase against this one instead of master ?

Thank you!

vandalt commented 2 years ago

Converted to draft because I just realized there is a bug when Q < 0.5 because the real terms are array. I'll try to use the (unused) 1and 3indices of CeleriteKernel.real to work around that.

vandalt commented 2 years ago

The issue with Q < 0.5 is now fixed, I added a test covering this as well.

vandalt commented 2 years ago

Marked as draft to rebase on #359, which refactors the GP API.

bjfultn commented 1 year ago

Is this still a WIP?

sblunt commented 1 year ago

Yeah, we'll need to reimplement the celerite functionality based on the tinygp refactor in #363

vandalt commented 1 year ago

Unfortunately could not work on this lately. I'm hoping to have time this winter, but in the meantime anyone feel free to take over!