search

California-Planet-Search / radvel

General Toolkit for Modeling Radial Velocity Data
http://radvel.readthedocs.io
MIT License
57 stars 52 forks source link

Fix multipanel plots #362

Closed sealauren closed 2 years ago

sealauren commented 2 years ago

I tried to test the changes, but too much of my stuff is split between cadence and my laptop to do a thorough test. I got the primary error message about Multipanel plots to go away. I also fixed the "residual" panel so that it doesn't show a slope.

bjfultn commented 2 years ago

Looks like a minor error from Travis:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/code/radvel/radvel/tests/test_api.py", line 139, in test_celerite
    radvel.driver.plots(args)
  File "/code/radvel/radvel/driver.py", line 75, in plots
    GPPlot.plot_multipanel()
  File "/code/radvel/radvel/plot/orbit_plots.py", line 695, in plot_multipanel
    figheight = self.ax_rv_height*(n_likes//phase_ncols+1.5) + self.ax_phase_height * scalefactor
NameError: name 'phase_ncols' is not defined

I suspect it should be self.phase_ncols?

sealauren commented 2 years ago

Right!

On Wed, Jan 26, 2022 at 6:30 PM BJ Fulton @.***> wrote:

Looks like a minor error from Travis:

Traceback (most recent call last): File "/usr/local/lib/python3.10/site-packages/nose/case.py", line 197, in runTest self.test(self.arg) File "/code/radvel/radvel/tests/test_api.py", line 139, in test_celerite radvel.driver.plots(args) File "/code/radvel/radvel/driver.py", line 75, in plots GPPlot.plot_multipanel() File "/code/radvel/radvel/plot/orbit_plots.py", line 695, in plot_multipanel figheight = self.ax_rv_height(n_likes//phase_ncols+1.5) + self.ax_phase_height * scalefactor NameError: name 'phase_ncols' is not defined

I suspect it should be self.phase_ncols?

— Reply to this email directly, view it on GitHub https://github.com/California-Planet-Search/radvel/pull/362#issuecomment-1022699228, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFG7SQ6F44OY42T7VE5TTUYB7ZHANCNFSM5M4GRWVA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>