Closed sblunt closed 11 months ago
Oh one other thing-- I found and fixed a bug with the gamma subtraction that looked to be introduced with the new vector formulation. We should check that gamma subtraction is working correctly for non-GP fits.
Can you resolve the conflicts
Ofc. I'm still testing this branch so I'll resolve conflicts and let you know when it's ready to be merged.
Continuation of #359. I gutted the
radvel
GP API to use Dan Foreman-Mackey's newtinygp
package, which is super flexible in terms of defining custom kernels. This is a pretty big change, so I'd consider releasing a new version number.A few notes:
celerite
, so if we want to add that back we'll have to reimplement itic_compare
n planet test in the unit tests isn’t working on my computer— I don’t usually use that functionality, so not sure what might be going on there.tinygp
!