search

California-Planet-Search / radvel

General Toolkit for Modeling Radial Velocity Data
http://radvel.readthedocs.io
MIT License
57 stars 52 forks source link

Fix for Cython installation issue #380

Closed lheinke closed 11 months ago

lheinke commented 1 year ago

I added a pyproject.toml file (see here for brief explanation) to ensure Cython gets installed before the radvel project gets installed/built. If this is not ensured, the installation might fail as several people have noticed before (https://github.com/California-Planet-Search/radvel/issues/375, https://github.com/California-Planet-Search/radvel/issues/237).

I verified that the installation works without Cython pre-installed using a conda environment with just the base Python installation by running a local install using pip install -e ..

I also encountered an error with numpy that has already been mentioned in pull request https://github.com/California-Planet-Search/radvel/pull/377. The setup.py was changed to provide a fix for this issue.

The current setup uses a minimal pyproject.toml and should probably be adapted according to the specification given here.