Closed lheinke closed 11 months ago
I added a pyproject.toml file (see here for brief explanation) to ensure Cython gets installed before the radvel project gets installed/built. If this is not ensured, the installation might fail as several people have noticed before (https://github.com/California-Planet-Search/radvel/issues/375, https://github.com/California-Planet-Search/radvel/issues/237).
pyproject.toml
Cython
radvel
I verified that the installation works without Cython pre-installed using a conda environment with just the base Python installation by running a local install using pip install -e ..
conda
pip install -e .
I also encountered an error with numpy that has already been mentioned in pull request https://github.com/California-Planet-Search/radvel/pull/377. The setup.py was changed to provide a fix for this issue.
numpy
setup.py
The current setup uses a minimal pyproject.toml and should probably be adapted according to the specification given here.
I added a
pyproject.toml
file (see here for brief explanation) to ensureCython
gets installed before theradvel
project gets installed/built. If this is not ensured, the installation might fail as several people have noticed before (https://github.com/California-Planet-Search/radvel/issues/375, https://github.com/California-Planet-Search/radvel/issues/237).I verified that the installation works without
Cython
pre-installed using aconda
environment with just the base Python installation by running a local install usingpip install -e .
.I also encountered an error with
numpy
that has already been mentioned in pull request https://github.com/California-Planet-Search/radvel/pull/377. Thesetup.py
was changed to provide a fix for this issue.The current setup uses a minimal
pyproject.toml
and should probably be adapted according to the specification given here.