California-Planet-Search / rvsearch

RV Planet Search Pipeline Based on RadVel
http://california-planet-search.github.io/rvsearch/
MIT License
10 stars 5 forks source link

Periodogram not displaying properly, rv fit not functioning properly #180

Closed zhexingli closed 4 years ago

zhexingli commented 4 years ago

rvsearch is returning some weird results. Periodogram not displaying properly, even though it detects a "signal" at around 2 days, which can be confirmed with another periodogram we have. But it's not displaying anything: dbic1.pdf

And the rv fit is not fitting anything, it's just fitting 100-day period for no reason: orbit_plot1.pdf

After the planet 1 fit is done, rvsearch then continues and somehow stuck in an endless for loop that keeps detecting the same super long, non-existing signal in the periodogram, but again not displaying it and rv fit repeatedly trying to fit more 100-day period signal: dbic4.pdf

orbit_plot4.pdf

Eventually I have to manually kill the program because it won't stop finding more "29120-day signal" and fitting more and more 100-day signal to rv...

rvsearch seems to work nicely for a lot of my other targets, except for some of the problems I posted on the issue tracker. But this is new...

The original data looks like this just in case you're curious:

data

And this is what the other periodogram returns:

FIT

And this is the code I'm using. I'm running from a script.

data = pd.read_csv(path,header=None,skiprows=0,delim_whitespace=True,names=('time','mnvel','errvel','tel'))

data['tel'] = 'inst1'

searcher = search.Search(data, starname='star1', min_per=2,workers=1, mcmc=False, verbose=True,trend=False,fap=0.001,mstar=[1.0,0.1])

searcher.run_search()

plotter = plots.PeriodModelPlot(searcher, saveplot=savepath+'PeriodSearch.png')

plotter.plot_summary()

zhexingli commented 4 years ago

It looks like my rvsearch decides to call a strike. Since the above reported problem occured, rvsearch's periodogram has been returning the same result (with the same display as the first attached pdf) regardless what dataset I'm using. Even for the exact same datasets in which I had detected signals using rvsearch weeks ago, the periodogram still returning the 2-day signal, but not displaying anything. Reinstall doesn't help. Now it's broken on my machine...

leerosenthalj commented 4 years ago

Hi Zhexing, what version of radvel do you have installed?

On Aug 21, 2020, at 1:39 AM, zhexingli notifications@github.com wrote:

 It looks like my rvsearch decides to call a strike. Since the above reported problem occured, rvsearch's periodogram has been returning the same result (with the same display as the first attached pdf) regardless what dataset I'm using. Even for the exact same datasets in which I had detected signals using rvsearch weeks ago, the periodogram still returning the 2-day signal, but not displaying anything. Reinstall doesn't help. Now it's broken on my machine...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

zhexingli commented 4 years ago

I think it's the latest version I'm using. Is it too new that's incompatiable with rvsearch? What version should I revert back to?

zhexingli commented 4 years ago

Yep this is indeed a version related issue. Running rvsearch now in a virtual environment with radvel 1.2.12 everything is working again.