search

California-Strawberry-Commission / laser-runner-cutter

2 stars 1 forks source link

aioros2 errors are swallowed #23

Open genkikondo opened 4 months ago

genkikondo commented 4 months ago

Steps to repro:

  1. In any aioros2 node (such as camera_control_node), add a @service that does not conform to the IDL (such as a missing or an extra param).
  2. Note that no errors are logged, and the node is in an unknown state.
DominicChm commented 3 months ago

Just noticed this one literally 30 minutes ago. Definitely some error handling code missing in service (and probably a few others). I can take a look and improve it. Need to merge some other aioros2 improvements too anyways so I'll include this as well.

DominicChm commented 2 months ago

This should be resolved by #27. Closing for now unless (until?) this pops up again.

genkikondo commented 2 days ago

Errors are still swallowed for subscriptions.